dsccommunity / StorageDsc

DSC resource module is used to manage storage on Windows Servers.

https://dsccommunity.org

MIT License

69 stars 51 forks source link

Disk-AccessPath: fixing get-partition to pull current state of object #198

Closed JoshuaJSwain closed 5 years ago

JoshuaJSwain commented 5 years ago

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Task list

[x] Added an entry under the Unreleased section of the change log in the CHANGELOG.md. Entry should say what was changed, and how that affects users (if applicable).
[ ] Resource documentation added/updated in README.md in the resource folder.
[ ] Resource parameter descriptions added/updated in schema.mof and comment-based help.
[ ] Comment-based help added/updated.
[ ] Localization strings added/updated in all localization files as appropriate.
[ ] Examples appropriately added/updated.
[x] Unit tests added/updated. See DSC Resource Testing Guidelines.
[ ] Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
[ ] New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is

codecov-io commented 5 years ago

Codecov Report

Merging #198 into dev will increase coverage by <1%. The diff coverage is 100%.

@@         Coverage Diff         @@
##           dev   #198    +/-   ##
===================================
+ Coverage   94%    94%   +<1%     
===================================
  Files        8      8            
  Lines      889    890     +1     
===================================
+ Hits       837    838     +1     
  Misses      52     52

JoshuaJSwain commented 5 years ago

Updated with the patch. I want to run this through some integration tests before calling it good.

JoshuaJSwain commented 5 years ago

Updated with the patch. I want to run this through some integration tests before calling it good.

I've tested this in a live environment and confirmed this fix.

PlagueHO commented 5 years ago

@JoshuaJSwain - when this one https://github.com/PowerShell/StorageDsc/pull/201 goes through then you can rebase and see if your tests still pass (I'd expect some to fail).

PlagueHO commented 5 years ago

Ok @JoshuaJSwain - #201 has gone through. Can you rebase and see if your tests pass and correct if necessary?

PlagueHO commented 5 years ago

Hi @JoshuaJSwain - this is what I expected- the tests to fail as they weren't actually very good. Now they are better tests you will need to correct them to validate your code correctly.

JoshuaJSwain commented 5 years ago

I take a look at this one week of 4/8. Should be straight forward to fix them up. Thanks!

Josh Swain

On Thu, Mar 28, 2019, 5:25 AM Daniel Scott-Raynsford < notifications@github.com> wrote:

Hi @JoshuaJSwain https://github.com/JoshuaJSwain - this is what I expected- the tests to fail as they weren't actually very good. Now they are better tests you will need to correct them to validate your code correctly.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/PowerShell/StorageDsc/pull/198#issuecomment-477493451, or mute the thread https://github.com/notifications/unsubscribe-auth/AdawlETt0V1NeKeptgjAxeYQIHwPuTKMks5vbHpBgaJpZM4bdbOw .