dsccommunity / StorageDsc

DSC resource module is used to manage storage on Windows Servers.
https://dsccommunity.org
MIT License
69 stars 51 forks source link

Added option to specify disk by 'Location' property #212

Closed ianwalkeruk closed 4 years ago

ianwalkeruk commented 5 years ago

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Task list


This change is Reviewable

msftclas commented 5 years ago

CLA assistant check
All CLA requirements met.

codecov-io commented 5 years ago

Codecov Report

Merging #212 into dev will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@        Coverage Diff         @@
##           dev   #212   +/-   ##
==================================
  Coverage   95%    95%           
==================================
  Files        7      7           
  Lines      978    978           
==================================
  Hits       937    937           
  Misses      41     41
PlagueHO commented 5 years ago

Great stuff @ianwalkeruk - I'll start the review once the tests are passing. Very cool to get this feature added.

ianwalkeruk commented 5 years ago

Great stuff @ianwalkeruk - I'll start the review once the tests are passing. Very cool to get this feature added.

Thanks - it's a lot deeper into Pester than I've ever been before, which is enjoyable but slow!

ianwalkeruk commented 5 years ago

I had to remove the integration tests, because the MSTF_Disk CIM resource had a null value for Location on the Appveyor platform. Unit tests all work fine.