dsccommunity / StorageDsc

DSC resource module is used to manage storage on Windows Servers.
https://dsccommunity.org
MIT License
69 stars 51 forks source link

Disk: Update Size value in example #215

Closed fullenw1 closed 4 years ago

fullenw1 commented 4 years ago

This Pull Request (PR) fixes the following issues

A value with a size unit (like MB or GB) does not work. It generates the following error message:

Compilation errors occurred while processing configuration 'DscConfigurationName'. Please review the errors reported in error stream and modify your configuration code appropriately. CategoryInfo : InvalidOperation: (DscConfiguration:String) [], InvalidOperationException FullyQualifiedErrorId : FailToProcessConfiguration

Entering only a number works fine.

Task list


This change is Reviewable

codecov-io commented 4 years ago

Codecov Report

Merging #215 into dev will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@        Coverage Diff         @@
##           dev   #215   +/-   ##
==================================
  Coverage   95%    95%           
==================================
  Files        7      7           
  Lines      980    980           
==================================
  Hits       939    939           
  Misses      41     41
PlagueHO commented 4 years ago

Can you add an entry into the CHANGELOG.MD for this change?

PlagueHO commented 4 years ago

Closing because superseded by #218