dsccommunity / StorageDsc

DSC resource module is used to manage storage on Windows Servers.
https://dsccommunity.org
MIT License
69 stars 51 forks source link

MSFT_MountImage - Correcting example for dismounting an ISO image #222

Closed wsmelton closed 3 years ago

wsmelton commented 4 years ago

Pull Request (PR) description

The drive letter should not be provided when wanting to ensure an ISO is no longer mounted.

This Pull Request (PR) fixes the following issues

Task list


This change is Reviewable

PlagueHO commented 4 years ago

Sorry about the delay @wsmelton - we've been a bit focused on the migration process over to the DSC Community. I've updated the build so that we can get this through.

codecov[bot] commented 4 years ago

Codecov Report

Merging #222 into dev will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@        Coverage Diff         @@
##           dev   #222   +/-   ##
==================================
  Coverage   95%    95%           
==================================
  Files        7      7           
  Lines      985    985           
==================================
  Hits       943    943           
  Misses      42     42
PlagueHO commented 4 years ago

Hi @wsmelton - can you resolve the conflicts and correct the error: https://ci.appveyor.com/project/dsccommunity/storagedsc/builds/29743806?fullLog=true#L615

It just looks like the line length in the CHANGELOG.MD is beyond the 80 char limit.

wsmelton commented 4 years ago

So this would assume then that your test does not account for URL links being provided? If you ignore the URL link the whole line is only 71 characters.

PlagueHO commented 4 years ago

Hi @wsmelton - now that we've updated to the new pipeline/structure, are you still keen to complete this one?