search

dsccommunity / UpdateServicesDsc

This module contains community maintained DSC resources for deployment and configuration of Windows Server Update Services.
MIT License
31 stars 27 forks source link

[UpdateServicesServer]: master branch resource mistype in if statement for #ClientTargetingMode check #46

Closed phoenix2pm closed 4 years ago

phoenix2pm commented 4 years ago

Details of the scenario you tried and the problem that is occurring

UpdateServicesServer: Set-TargetResource mistype in check #ClientTargetingMode spaces in "Client Targeting Mode", wherefore test is failing and DSC is throwing error

#ClientTargetingMode
        if($PSBoundParameters.ContainsKey("Client Targeting Mode"))

Verbose logs showing the problem

Suggested solution to the issue

Merge dev branch which has correct syntax to master branch.

The DSC configuration that is used to reproduce the issue (as detailed as possible)

The operating system the target node is running

Version and build of PowerShell the target node is running

Version of the DSC module that was used ('dev' if using current dev branch)

master

Firefishy commented 4 years ago

This appears to be fixed on the master branch and the v1.2.0 preview release https://github.com/dsccommunity/UpdateServicesDsc/releases/tag/v1.2.0-preview0001

Firefishy commented 4 years ago

@johlju ^

johlju commented 4 years ago

Great thank you! Closing this as fixed.