dsccommunity / UpdateServicesDsc

This module contains community maintained DSC resources for deployment and configuration of Windows Server Update Services.
MIT License
31 stars 27 forks source link

Added Sampler.GitHubTasks in build.yaml #70

Closed NicolasBn closed 2 years ago

NicolasBn commented 2 years ago

Pull Request (PR) description

Edit : There is an issue in AzurePipeline. The deploy job try to found ublish_release_to_GitHub task. But it was present in Sampler.GitHubTasks module which isn't referenced in build.yaml

This Pull Request (PR) fixes the following issues

Task list


This change is Reviewable

johlju commented 2 years ago

I think you a mistaken. It has not been deprecated. It is used to add a PR for the changelog. Though it can be added after the task that publish module to gallery.

johlju commented 2 years ago

You are missing this in the build.yaml https://github.com/dsccommunity/SqlServerDsc/blob/a9850f2a0d145c15a2a19d23bf20ff670fce17fa/build.yaml#L48-L49

NicolasBn commented 2 years ago

Oh ! Indeed ! I forgot to check in Sampler.GitHubTasks module ... I'll correct this PR.

NicolasBn commented 2 years ago

Are the Create_ChangeLog_GitHub_PR task and Publish_GitHub_Wiki_Content task needed?

gaelcolas commented 2 years ago

The GitHub PR yes The GitHub wiki maybe not as the repo might not be ready for it (wiki not created)

johlju commented 2 years ago

If you are using the latest template files from the dsccommunity-template in Sampler you should be able to run the latest ModuleBuilder. But that can be another PR.