dsccommunity / UpdateServicesDsc

This module contains community maintained DSC resources for deployment and configuration of Windows Server Update Services.
MIT License
31 stars 27 forks source link

Fix tests, minor style issues, offline CAB update #80

Closed Borgquite closed 2 months ago

Borgquite commented 3 months ago

Pull Request (PR) description

@johlju Have started work on this module with a lot of small ‘cleanup’ tasks.

Hopefully there’s no argument over these changes - gets the tests working, fixes some dodgy strings, updates the offline CAB, adds some additional Classification GUIDs to the notes for convenience. It should hopefully be a quick and easy one for review & approval :)

This Pull Request (PR) fixes the following issues

None

Task list


This change is Reviewable

Borgquite commented 3 months ago

@johlju Are you able to take a look at this sometime please?

johlju commented 3 months ago

When I have time I will take a look. 🙂

johlju commented 2 months ago

Thanks for the detailed explanation! 🙂 So to be able to do this in the pipeline, we would have to install a WSUS server, sync it to MS Update and configure the new classifications and products then run the command. Would it be feasible to do all that without user intervention for each deploy in Azure Pipelines on a Win2022 Server build worker within its 4 hour run time?

johlju commented 2 months ago

The diff of the .cab file is so large so it is not feasible to review it, I have to assume it is correct and valid. 🙂

johlju commented 2 months ago

I added issue #81 to track if there is a way to automate generating the .cab file.