dsccommunity / WSManDsc

DSC resources for configuring WS-Management and PowerShell Remoting.
https://dsccommunity.org
MIT License
19 stars 8 forks source link

WSManDsc: Convert Tests to Pester 5 #105

Closed dan-hughes closed 2 months ago

dan-hughes commented 4 months ago

Pull Request (PR) description

Convert tests to Pester 5

This Pull Request (PR) fixes the following issues

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98%. Comparing base (6f4163d) to head (7ecf82c). Report is 1 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/dsccommunity/WSManDsc/pull/105/graphs/tree.svg?width=650&height=150&src=pr&token=sfnbZH5JhA&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity)](https://app.codecov.io/gh/dsccommunity/WSManDsc/pull/105?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity) ```diff @@ Coverage Diff @@ ## main #105 +/- ## ==================================== + Coverage 88% 98% +10% ==================================== Files 3 3 Lines 310 292 -18 ==================================== + Hits 274 288 +14 + Misses 36 4 -32 ``` | [Files with missing lines](https://app.codecov.io/gh/dsccommunity/WSManDsc/pull/105?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity) | Coverage Δ | | |---|---|---| | [.../DSCResources/DSC\_WSManConfig/DSC\_WSManConfig.psm1](https://app.codecov.io/gh/dsccommunity/WSManDsc/pull/105?src=pr&el=tree&filepath=source%2FDSCResources%2FDSC_WSManConfig%2FDSC_WSManConfig.psm1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity#diff-c291cmNlL0RTQ1Jlc291cmNlcy9EU0NfV1NNYW5Db25maWcvRFNDX1dTTWFuQ29uZmlnLnBzbTE=) | `100% <100%> (ø)` | | | [...Resources/DSC\_WSManListener/DSC\_WSManListener.psm1](https://app.codecov.io/gh/dsccommunity/WSManDsc/pull/105?src=pr&el=tree&filepath=source%2FDSCResources%2FDSC_WSManListener%2FDSC_WSManListener.psm1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity#diff-c291cmNlL0RTQ1Jlc291cmNlcy9EU0NfV1NNYW5MaXN0ZW5lci9EU0NfV1NNYW5MaXN0ZW5lci5wc20x) | `98% <100%> (+14%)` | :arrow_up: | | [...DSC\_WSManServiceConfig/DSC\_WSManServiceConfig.psm1](https://app.codecov.io/gh/dsccommunity/WSManDsc/pull/105?src=pr&el=tree&filepath=source%2FDSCResources%2FDSC_WSManServiceConfig%2FDSC_WSManServiceConfig.psm1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity#diff-c291cmNlL0RTQ1Jlc291cmNlcy9EU0NfV1NNYW5TZXJ2aWNlQ29uZmlnL0RTQ19XU01hblNlcnZpY2VDb25maWcucHNtMQ==) | `100% <100%> (ø)` | |
dan-hughes commented 4 months ago

@johlju, @PlagueHO,

Please can someone review when time permits?

PlagueHO commented 3 months ago

Thanks for submitting @dan-hughes - awesome stuff! I'll get onto reviewing in the weekend.

PlagueHO commented 3 months ago

Sorry for not getting onto this yet - have had some other issues come up that need to deal with. Might have to be in the week :/

PlagueHO commented 2 months ago

Just need to get @kilasuit to sign off on comment and can merge.

kilasuit commented 2 months ago

Good to merge :-)