dsccommunity / WSManDsc

DSC resources for configuring WS-Management and PowerShell Remoting.
https://dsccommunity.org
MIT License
19 stars 8 forks source link

BREAKING: `WSManListener`: Convert to a Class Resource #106

Open dan-hughes opened 1 month ago

dan-hughes commented 1 month ago

Pull Request (PR) description

Convert WSManListener to a class resource Rename parameter DN to BaseDN

This Pull Request (PR) fixes the following issues

Contributes to #98 Fixes #89

Task list


This change is Reviewable

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 91.40625% with 11 lines in your changes missing coverage. Please review.

Project coverage is 94%. Comparing base (4856433) to head (375f723).

Files with missing lines Patch % Lines
source/Classes/020.WSManListener.ps1 85% 10 Missing :warning:
source/Private/Find-Certificate.ps1 97% 1 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/dsccommunity/WSManDsc/pull/106/graphs/tree.svg?width=650&height=150&src=pr&token=sfnbZH5JhA&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity)](https://app.codecov.io/gh/dsccommunity/WSManDsc/pull/106?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity) ```diff @@ Coverage Diff @@ ## main #106 +/- ## =================================== - Coverage 98% 94% -5% =================================== Files 3 7 +4 Lines 292 200 -92 =================================== - Hits 288 189 -99 - Misses 4 11 +7 ``` | [Files with missing lines](https://app.codecov.io/gh/dsccommunity/WSManDsc/pull/106?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity) | Coverage Δ | | |---|---|---| | [source/Private/Get-DefaultPort.ps1](https://app.codecov.io/gh/dsccommunity/WSManDsc/pull/106?src=pr&el=tree&filepath=source%2FPrivate%2FGet-DefaultPort.ps1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity#diff-c291cmNlL1ByaXZhdGUvR2V0LURlZmF1bHRQb3J0LnBzMQ==) | `100% <100%> (ø)` | | | [source/Private/Get-Listener.ps1](https://app.codecov.io/gh/dsccommunity/WSManDsc/pull/106?src=pr&el=tree&filepath=source%2FPrivate%2FGet-Listener.ps1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity#diff-c291cmNlL1ByaXZhdGUvR2V0LUxpc3RlbmVyLnBzMQ==) | `100% <100%> (ø)` | | | [source/prefix.ps1](https://app.codecov.io/gh/dsccommunity/WSManDsc/pull/106?src=pr&el=tree&filepath=source%2Fprefix.ps1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity#diff-c291cmNlL3ByZWZpeC5wczE=) | `100% <100%> (ø)` | | | [source/Private/Find-Certificate.ps1](https://app.codecov.io/gh/dsccommunity/WSManDsc/pull/106?src=pr&el=tree&filepath=source%2FPrivate%2FFind-Certificate.ps1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity#diff-c291cmNlL1ByaXZhdGUvRmluZC1DZXJ0aWZpY2F0ZS5wczE=) | `97% <97%> (ø)` | | | [source/Classes/020.WSManListener.ps1](https://app.codecov.io/gh/dsccommunity/WSManDsc/pull/106?src=pr&el=tree&filepath=source%2FClasses%2F020.WSManListener.ps1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dsccommunity#diff-c291cmNlL0NsYXNzZXMvMDIwLldTTWFuTGlzdGVuZXIucHMx) | `85% <85%> (ø)` | |