dsccommunity / iSCSIDsc

DSC resources for configuring Windows iSCSI targets and initiators.
https://dsccommunity.org
MIT License
7 stars 9 forks source link

Refactored module folder structure to move resource to root folder of repository and remove test harness - Fixes #36 #38

Closed PlagueHO closed 5 years ago

PlagueHO commented 5 years ago

Pull Request (PR) description

This PR primarily refactors this project to remove the test harness.

It also includes these changes:

This Pull Request (PR) fixes the following issues

Task list

@johlju - this one is a bit of a big one, but is mainly just to remove the harness and prepare for publishing examples to PSGallery.


This change is Reviewable

codecov[bot] commented 5 years ago

Codecov Report

Merging #38 into dev will decrease coverage by 2%. The diff coverage is n/a.

Impacted file tree graph

@@        Coverage Diff        @@
##           dev   #38   +/-   ##
=================================
- Coverage   90%   87%   -3%     
=================================
  Files        3     4    +1     
  Lines      655   684   +29     
=================================
+ Hits       590   596    +6     
- Misses      65    88   +23
johlju commented 5 years ago

Couldn't find anything wrong with this one 😃

PlagueHO commented 5 years ago

Woop! Thanks @johlju !!!