dsccommunity / xDhcpServer

This module contains DSC resources for deployment and configuration of Microsoft DHCP Server.
MIT License
26 stars 33 forks source link

New resources DhcpServerExclusionRange, DhcpServerBinding #54

Closed aromano2 closed 4 years ago

aromano2 commented 5 years ago

Pull Request (PR) description

Adding DhcpServerExclusionRange resource. Allows you to define an exclusion range for a specific scope. Also added DhcpServerBinding resource which allows you to control the behavior or network bindings within Dhcp.

This Pull Request (PR) fixes the following issues

Fixes #7 Fixes #55

Task list


This change is Reviewable

codecov-io commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@dc3ced4). Click here to learn what that means. The diff coverage is 94.54%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #54   +/-   ##
=========================================
  Coverage          ?   76.05%           
=========================================
  Files             ?       14           
  Lines             ?      998           
  Branches          ?        4           
=========================================
  Hits              ?      759           
  Misses            ?      235           
  Partials          ?        4
Impacted Files Coverage Δ
...rExclusionRange/MSFT_DhcpServerExclusionRange.psm1 94.54% <94.54%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dc3ced4...82a2704. Read the comment docs.

aromano2 commented 5 years ago

@johlju can anyone review this PR please?

stale[bot] commented 5 years ago

Labeling this pull request (PR) as abandoned since it has gone 14 days or more since the last update. An abandoned PR can be continued by another contributor. The abandoned label will be removed if work on this PR is taken up again.

esincic commented 5 years ago

Can anyone review this PR, please? Exclusions and bindings are very welcome in this cookbook.

johlju commented 5 years ago

I have a lot of PRs to review in my backlog but when I can I will help with the review in this one. But it will take a while. :/

If someone else would want to help out to review this one then please do, if there are any questions I’m happy to give pointers.

cwegener commented 5 years ago

These two resources would be great additions indeed.

Apart from performing code review, do the failed CI test need to be resolved as well before merging?

johlju commented 5 years ago

Yes, all tests need to pass for it to be merged.

aromano2 commented 5 years ago

@cwegener @johlju fixed the test, thanks!

stale[bot] commented 5 years ago

Labeling this pull request (PR) as abandoned since it has gone 14 days or more since the last update. An abandoned PR can be continued by another contributor. The abandoned label will be removed if work on this PR is taken up again.

johlju commented 5 years ago

@aromano2 I will review this one as soon as I have time. It gets labelled abandoned because it is not labelled 'needs review' and I can't label it. But I have this on the todo list to review!

/cc @gaelcolas when you have permission, could you please label this one?

gaelcolas commented 5 years ago

Labelled and turned off the stale bot. I'm going through the Abandoned PR, and will try to come back to review this one. Bear with us!

johlju commented 4 years ago

THis repo was converted to the new CI pipeline. I pushed changes to this PR so that the PR is up-to-date with those changes, and so that the PR is passing HQRM and unit testing.

johlju commented 4 years ago

Merging this to get this one through.