search

dsccommunity / xPendingReboot

MIT License
31 stars 10 forks source link

Script analyzer and formatting fixes fixes #19

Closed Chirishman closed 5 years ago

Chirishman commented 6 years ago

This change is Reviewable

johlju commented 6 years ago

@Chirishman Thanks for fixing style issues! Just a few review comments. 🙂

stale[bot] commented 6 years ago

Labeling this pull request (PR) as abandoned since it has gone 14 days or more since the last update. An abandoned PR can be continued by another contributor. The abandoned label will be removed if work on this PR is taken up again.

PlagueHO commented 5 years ago

@johlju - regarding the comment regarding regRebootLocations - I had the exact same thought as you when I encountered it. It seems to go back right to the very first commit of this resource. The purpose is a bit of a mystery. Perhaps @joeyaiello can shed some light on the purpose? If not, I'm going to delete it as part of the migration to ComputerManagementDsc.

PlagueHO commented 5 years ago

Hi @Chirishman - this resource is actually being migrated into ComputerManagementDsc and updated to meet HQRM at the same time. So there might not be too much need to continue this PR. Sorry, I missed this work being done so didn't alert you earlier - it was being discussed in one of the other issues in this repo.

gaelcolas commented 5 years ago

As per @johlju point, I'm going to close this one and wait for the merge to CptMgtDsc. Thanks!