dsccommunity / xRemoteDesktopSessionHost

This module contains DSC resources for the management and configuration of Microsoft Remote Desktop Session Host (RDSH).
MIT License
36 stars 47 forks source link

xRDSessionCollection: Resolve Issue 106; always filter Get-RDSessionCollection result set #107

Closed uw-dc closed 1 year ago

uw-dc commented 2 years ago

Pull Request (PR) description

RDSessionCollection's Get-TargetResource has been amended so that it filters the RD Session Collections returned from Get-RDSessionCollection on CollectionName matching the desired $CollectionName, in all circumstances.

PR also contains an attempt to improve the testing in this area.

This Pull Request (PR) fixes the following issues

Task list


This change is Reviewable

codecov[bot] commented 2 years ago

Codecov Report

Merging #107 (784843c) into master (b97c82b) will increase coverage by 0%. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #107   +/-   ##
=====================================
  Coverage      88%    89%           
=====================================
  Files           9      9           
  Lines         461    470    +9     
=====================================
+ Hits          410    419    +9     
  Misses         51     51           
Impacted Files Coverage Δ
...RDSessionCollection/MSFT_xRDSessionCollection.psm1 96% <100%> (+1%) :arrow_up:
uw-dc commented 2 years ago

if #109 is merged, this PR can be deleted