dsccommunity / xRemoteDesktopSessionHost

This module contains DSC resources for the management and configuration of Microsoft Remote Desktop Session Host (RDSH).
MIT License
36 stars 47 forks source link

Implemented Validation of Collection Name Length Issue 10 #13

Closed JimPriestley closed 7 years ago

JimPriestley commented 7 years ago

Character length 1-15 characters Added Tests for impacted resources Updated Documentaion Added Missing new-line at end of .gitignore and the common PSM


This change is Reviewable

msftclas commented 7 years ago

Hi @JimPriestley, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

JimPriestley commented 7 years ago

This is my first ever pull request, so I picked something simple. Please let me know if I'm missing anything.

kwirkykat commented 7 years ago

@JimPriestley Closing and re-opening the PR to try to get the CLA bot to re-trigger.

msftclas commented 7 years ago

Hi @JimPriestley, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

JimPriestley commented 7 years ago

Reopening to clear CLA-Required now that I joined the MS GitHub Org

msftclas commented 7 years ago

Hi @JimPriestley, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Jim Priestley). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

JimPriestley commented 7 years ago

I'm going to close this PR and create a new fork and PR to solve for the broken .gitignore file.