Closed stiwenn closed 7 years ago
This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request. Thanks, Microsoft Pull Request Bot
Hi @stiwenn,
You can update one of these outstanding PRs so one of these contain all the changes or close them and open up 1 new one containing all the code that makes this one change.
Thank you!
Hi Ben,
Thank you for reply.
Yes. Those changes needs to be done in MSFT_xRDRemoteApp.schema.mof and MSFT_xRDRemoteApp.psm1 files. Otherwise it will not work.
To be honest I'm new GitHub user, but I will try to add #18 #19 into one PR.
Best Regards
Thanks @stiwenn Please have a look at the getting started guide that is available to help you out!
Hello Ben,
Please check:
https://github.com/PowerShell/xRemoteDesktopSessionHost/pull/22
I think now #18 https://github.com/PowerShell/xRemoteDesktopSessionHost/pull/18 and #19 https://github.com/PowerShell/xRemoteDesktopSessionHost/pull/19 can be removed.
Best Regards, stiwen1
2017-06-10 9:21 GMT+02:00 Ben Gelens notifications@github.com:
Thanks @stiwenn https://github.com/stiwenn Please have a look at the getting started guide https://github.com/PowerShell/DscResources/blob/master/GettingStartedWithGitHub.md that is available to help you out!
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/PowerShell/xRemoteDesktopSessionHost/pull/18#issuecomment-307548509, or mute the thread https://github.com/notifications/unsubscribe-auth/AbTJwyj3db5XyX6yNB2k9UEkebzw4fS6ks5sCkQEgaJpZM4NYCio .
UserGroups should be set as a string table. Otherwise there will be not possible to define more than one user or group to be added to particular remote app. This update solves following issue:
https://gallery.technet.microsoft.com/scriptcenter/xRemoteDesktopSessionHost-4a11f27d/view/Discussions#content
Post described as "Problem with attribute UserGroups in xRDRemoteApp".
This change is