search

dsccommunity / xRemoteDesktopSessionHost

This module contains DSC resources for the management and configuration of Microsoft Remote Desktop Session Host (RDSH).
MIT License
36 stars 47 forks source link

Update MSFT_xRDRemoteApp.psm1 #19

Closed stiwenn closed 7 years ago

stiwenn commented 7 years ago

$UserGroups should be set as a string table (the same modification needs to be done in MSFT_xRDRemoteApp.schema.mof). Otherwise there will be not possible to define more than one user or group to be added to particular remote app. This update solves following issue:

https://gallery.technet.microsoft.com/scriptcenter/xRemoteDesktopSessionHost-4a11f27d/view/Discussions#content

Post described as "Problem with attribute UserGroups in xRDRemoteApp".

This change is Reviewable

msftclas commented 7 years ago

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request. Thanks, Microsoft Pull Request Bot

bgelens commented 7 years ago

Hi @stiwenn,

18 and #19 are a combined change. Could you add #18 #19 into one PR instead of these two desegregated ones?

You can update one of these outstanding PRs so one of these contain all the changes or close them and open up 1 new one containing all the code that makes this one change.

Thank you!