Closed KennethVerbeure closed 6 years ago
Reviewed 1 of 1 files at r1. Review status: all files reviewed at latest revision, all discussions resolved.
Comments from Reviewable
Hi @KennethVerbeure apologies for the delay in looking at your PR, I've only recently become a maintainer, unfortunately a PR I just merged has created a conflict with your branch (#29), The change was purely style and formatting so should change anything directly relating to your PR. If your still interested in contributing to the module would you be able to update your PR and add an entry to the unreleased section on the README.md file please?
Merging #24 into dev will decrease coverage by
0.13%
. The diff coverage is0%
.
@@ Coverage Diff @@
## dev #24 +/- ##
=========================================
- Coverage 16.1% 15.96% -0.14%
=========================================
Files 5 5
Lines 118 119 +1
Branches 4 4
=========================================
Hits 19 19
- Misses 95 96 +1
Partials 4 4
Impacted Files | Coverage Δ | |
---|---|---|
...RDSessionDeployment/MSFT_xRDSessionDeployment.psm1 | 18.75% <0%> (-1.25%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 2a6b79a...96ed2c0. Read the comment docs.
Reviewed 1 of 1 files at r2, 1 of 1 files at r3. Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.
Comments from Reviewable
@ld0614 i have no idea why now i got failing checks, all i did was merge with your DEV branch and edit the readme
Hi @KennethVerbeure The checks are failing as part of my change I enabled codecoverage scoring. This repo is configured to fail a check if the code coverage score decreases and if your code has a lower test coverage than average (currently 16%). Unless someone specifically shoots me down (@kwirkykat) as the current unit testing state is so poor I'm ignoring them at the moment. My plan is to get at least a basic set of unit tests in place prior to enforcing these guidelines.
@KennethVerbeure @ld0614 Yes you can completely ignore the 'failed' code coverage check for this repo
Thanks for the Confirmation @kwirkykat and thanks @KennethVerbeure for the contribution
Fix issue where DSC configuration gets into a reboot loop because sessionhost does not match (casing) and RDMS service is not started in time
original issue/fix: https://gallery.technet.microsoft.com/scriptcenter/xRemoteDesktopSessionHost-4a11f27d/view/Discussions
This change is