search

dsccommunity / xRemoteDesktopSessionHost

This module contains DSC resources for the management and configuration of Microsoft Remote Desktop Session Host (RDSH).
MIT License
36 stars 47 forks source link

Fix false positive when another Collection exists #26

Closed RobBiddle closed 6 years ago

RobBiddle commented 6 years ago

The Test was passing when a Collection with a different name was present.

Added CollectionName and ConnectionBroker to Get-TargetResource (which is referenced by Test-TargetResource) to prevent the test from passing when a Collection with a different name exists.

This change is Reviewable

RobBiddle commented 6 years ago

Microsoft Contribution Licensing Agreement (CLA) has been signed

ld0614 commented 6 years ago

Hi @RobBiddle

Thanks for the PRs, would you be able to update the readme for this change please as it could impact existing builds which rely on this 'feature'. Notes here

ld0614 commented 6 years ago

Thanks for the update @RobBiddle,

I noticed that you've created issues to associate with these PRs, would you just be able to append to the title of the PRs to state that they fix the associated issue please?

Sorry if my above comment gave the wrong impression, I don't believe that this change would be classed as a breaking change as it doesn't meet the bar set here, I think something nice and succinct such as 'Fixed an issue where xRDSessionCollection would return true if any collection existed' would suffice, Happy to discuss further 😃

ld0614 commented 6 years ago

Apologies @RobBiddle a PR I mergedwhich basically resolved a lot of PSSA issues (#29) with the module is now causing a conflict with your PR. Functionally the PR didn't change anything it just updated some of the formatting and style.

johlju commented 6 years ago

Labeling this PR as abandoned since it has gone 14 days or more since the last update. An abandoned PR can be continued by another contributor. The abandoned label will be removed if work on the PR is taken up again.