Closed danielboth closed 6 years ago
Merging #38 into dev will increase coverage by
3.79%
. The diff coverage is100%
.
@@ Coverage Diff @@
## dev #38 +/- ##
=========================================
+ Coverage 69.1% 72.89% +3.79%
=========================================
Files 8 8
Lines 369 369
Branches 9 9
=========================================
+ Hits 255 269 +14
+ Misses 105 91 -14
Partials 9 9
Impacted Files | Coverage Δ | |
---|---|---|
...RDSessionCollection/MSFT_xRDSessionCollection.psm1 | 94.73% <100%> (+73.68%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 2120fde...c58d360. Read the comment docs.
@danielboth Thanks for continuing the work on those PR's!
Just one minor comment.
Reviewed 2 of 3 files at r1, 1 of 1 files at r3. Review status: all files reviewed, 1 unresolved discussion (waiting on @danielboth)
README.md, line 128 at r3 (raw file):
* Added additional resources, copied from the [Azure RDS quickstart templates](https://github.com/Azure/RDS-Templates). * xRDSessionCollection: Bugfixes for #27 and #28 and adding tests for this resource.
Could we make this a little more descriptive so the users now what the change is?
For example.
* xRDSessionCollection:
* Change/No longer/Fixed ...some more text... (issue #27).
* Change/No longer/Fixed ...some more text... (issue #28).
Comments from Reviewable
Fixed the descriptions @johlju, should be good now.
Awesome! Thanks for this!
Reviewed 1 of 1 files at r4. Review status: :shipit: complete! all files reviewed, all discussions resolved
Comments from Reviewable
On this repository two abandoned pull requests are open which would have fixed #27 and fixed #28. Those were done by @RobBiddle. Since those pull requests are not being merged, but the issues fixed in those are still very valid, I grabbed the changes of those two and added them in this pull request. This also adds unit tests for xRDSessionCollection.
Closes #25 Closes #26
This change is