Closed danielboth closed 6 years ago
Merging #42 into dev will increase coverage by
12.13%
. The diff coverage is100%
.
@@ Coverage Diff @@
## dev #42 +/- ##
===========================================
+ Coverage 72.89% 85.03% +12.13%
===========================================
Files 8 8
Lines 369 381 +12
Branches 9 9
===========================================
+ Hits 269 324 +55
+ Misses 91 48 -43
Partials 9 9
Impacted Files | Coverage Δ | |
---|---|---|
...RDSessionDeployment/MSFT_xRDSessionDeployment.psm1 | 94.73% <100%> (+75.98%) |
:arrow_up: |
...Resources/MSFT_xRDRemoteApp/MSFT_xRDRemoteApp.psm1 | 97.77% <100%> (+86.66%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 5ef201d...1cede36. Read the comment docs.
Hi @ld0614, are you available to review this one?
Something strange is going on with Reviewable. Closing an reopening to see if it correct it self. The reviewable button pointed to ComputerManagementDsc for some reason.
@ld0614 since you are the maintainer for this repository, are you okay with this change?
Ah, I forgot that the change log get messed up when a release happened. Every time I miss this. 😄 The things that was under the unreleased section is merged onto the latest version instead. I will fix this.
Pull Request (PR) description This PR adds bugfixes and tests for the xRDSessionDeployment and xRDRemoteApp resources. It also adds the capability to xRDRemoteApp to uninstall RemoteApps after they have been deployed, this PR enables describing these as Absent.
This Pull Request (PR) fixes the following issues: xRDSessionDeployment Results in "You cannot call a method on a null-valued expression." Fixes #39 xRemoteApp: Ignores the CollectionName set by the user. Fixes #41
Task list:
This change is