xRDSessionDeployment, xRDServer: fixes

dsccommunity / xRemoteDesktopSessionHost

This module contains DSC resources for the management and configuration of Microsoft Remote Desktop Session Host (RDSH).

MIT License

36 stars 47 forks source link

xRDSessionDeployment, xRDServer: fixes #55

Closed peppekerstens closed 5 years ago

peppekerstens commented 6 years ago

Pull Request (PR) description

Fixes issues found in resources.

This Pull Request (PR) fixes the following issues

Fixes #47 Fixes #50

Task list

[X] Added an entry under the Unreleased section of the change log in the README.md. Entry should say what was changed, and how that affects users (if applicable).
[ ] Resource documentation added/updated in README.md.
[ ] Resource parameter descriptions added/updated in README.md, schema.mof and comment-based help.
[ ] Comment-based help added/updated.
[ ] Localization strings added/updated in all localization files as appropriate.
[ ] Examples appropriately added/updated.
[X] Unit tests added/updated. See DSC Resource Testing Guidelines.
[ ] Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
[ ] New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is

peppekerstens commented 6 years ago

Hi Johan,

Retry. Again there are more files changed then should be. Problem is that i get presented with untracked or changed files when downloading the xRemoteDesktopSessionHost 'clean' on my machine. Which is very....odd. You can see which ones they are; first commit. When is test other repo's (sqlServerDsc for instance), i have no issues...

Other commits are just a recap of previous work.

johlju commented 6 years ago

@peppekerstens Ah, that's because they were committed with the wrong line encoding, with the .gitattributes file fixes!

@ld0614 since you are a maintainer of this repository, could you possible send in a PR merging in the offending files with the correct line encoding? Just clone to a new folder and you should see files to stage into a PR.

johlju commented 6 years ago

@peppekerstens btw you haven't done anything wrong. The wrong line encodings were there from the beginning. 🙂

peppekerstens commented 6 years ago

appveyor build faillure seems to be unrelated to the code (time-out due to hang on certificate error) can you please re-initiate a build?

stale[bot] commented 5 years ago

Labeling this pull request (PR) as abandoned since it has gone 14 days or more since the last update. An abandoned PR can be continued by another contributor. The abandoned label will be removed if work on this PR is taken up again.

gaelcolas commented 5 years ago

Now that #57 has been merged, could you try to rebase from the remote's dev branch head and force push to update the PR (and trigger another build)?