dsccommunity / xRemoteDesktopSessionHost

This module contains DSC resources for the management and configuration of Microsoft Remote Desktop Session Host (RDSH).

MIT License

35 stars 47 forks source link

Fix xRDSessionDeployment Get-Targetresource to target connection broker #68

Closed danielboth closed 4 years ago

danielboth commented 4 years ago

Pull Request (PR) description

Small fix to Get-TargetResource in xRDSessionDeployment to not assume the connection broker as localhost, but to use the input from the user.

This PR includes some small fixes to the syntax of the file and it's tests.

This Pull Request (PR) fixes the following issues

Fixes #53

Task list

[X] Added an entry under the Unreleased section of the change log in the README.md. Entry should say what was changed, and how that affects users (if applicable).
[ ] Resource documentation added/updated in README.md.
[ ] Resource parameter descriptions added/updated in README.md, schema.mof and comment-based help.
[ ] Comment-based help added/updated.
[ ] Localization strings added/updated in all localization files as appropriate.
[ ] Examples appropriately added/updated.
[ ] Unit tests added/updated. See DSC Resource Testing Guidelines.
[ ] Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
[X] New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is

codecov-io commented 4 years ago

Codecov Report

Merging #68 into dev will not change coverage. The diff coverage is 83.33%.

@@          Coverage Diff          @@
##             dev     #68   +/-   ##
=====================================
  Coverage   87.4%   87.4%           
=====================================
  Files          8       8           
  Lines        381     381           
  Branches       9       9           
=====================================
  Hits         333     333           
  Misses        39      39           
  Partials       9       9

Impacted Files	Coverage Δ
...RDSessionDeployment/MSFT_xRDSessionDeployment.psm1	`94.73% <83.33%> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a2c0281...3f367d4. Read the comment docs.

gaelcolas commented 4 years ago

The change looks good, but if it's a fix, is it possible to add a test that would have failed before and would now pass? I'm not saying that should be a blocking point for that release, unless @ld0614 has an objection, but it'd be great to ensure non-regression.

danielboth commented 4 years ago

Thanks @gaelcolas, I've added a test.

gaelcolas commented 4 years ago

Feel free to merge when and how you feel it's best ;)