dsccommunity / xRemoteDesktopSessionHost

This module contains DSC resources for the management and configuration of Microsoft Remote Desktop Session Host (RDSH).

MIT License

35 stars 47 forks source link

Adding normalization for parameter and current values #83

Closed jeremyciak closed 4 years ago

jeremyciak commented 4 years ago

Pull Request (PR) description

Adding normalization for parameter and current values

This Pull Request (PR) fixes the following issues

82

Task list

[x] Added an entry under the Unreleased section of file CHANGELOG.md. Entry should say what was changed, and how that affects users (if applicable).
[x] Resource documentation added/updated in README.md.
[x] Resource parameter descriptions added/updated in README.md, schema.mof and comment-based help.
[x] Comment-based help added/updated.
[x] Localization strings added/updated in all localization files as appropriate.
[x] Examples appropriately added/updated.
[x] Unit tests added/updated. See DSC Community Testing Guidelines.
[x] Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
[x] New/changed code adheres to DSC Community Style Guidelines.

This change is

danielboth commented 4 years ago

Hi @jeremyciak, sorry for the delay in response. I had a look at this PR and remembered about Test-DscParameterState, a function that is included in the DscRsource.Common module (see here: https://github.com/dsccommunity/DscResource.Common/blob/master/source/Public/Test-DscParameterState.ps1). I think that might be the way to fix this, but I did not have time to test integrating that module yet, would you be up for that?

As an intermediate step we could also merge your code in it's current form, although I would prefer the previous. Let me know your thoughts.

jeremyciak commented 4 years ago

@danielboth, I believe I have a functional implementation of the Test-DscParameterState function, which of course has set the foundation to implement this and other functions from the DscResource.Common module across more DSC resources in this xRemoteDesktopSessionHost module.

danielboth commented 4 years ago

Hi @jeremyciak, thanks for this work, looks good at first sight! I'll do my best to do a full review by tomorrow.

jeremyciak commented 4 years ago

@danielboth, alright thanks! I also have a lot of other fixes that I would love to implement so if all goes well here you can expect more Issues and PR's to come through. I'm curious how does one become an official Contributor for this repository?

danielboth commented 4 years ago

Hi @jeremyciak, just some minor things in the review, if you can change / update those we're ready for merge.

You become an official contributor the first time you merge a PR, so once this one is approved & merged.

jeremyciak commented 4 years ago

@danielboth, I suppose the question I was really meaning to ask was how to become a Reviewer and not just a Contributor

jeremyciak commented 4 years ago

@danielboth, how do I join this DSC community call? Also, does this PR need to be merged to master?

danielboth commented 4 years ago

Hi @jeremyciak, yes this PR needs to be merged to master. After it gets merged, we'll do an automatic release of the module with a preview tag (e.g. 2.0.0-preview0004). You should be able to merge this PR now, so please go ahead and do that.

On the DSC community, you can get more information here: https://dsccommunity.org/community_calls/. Also, for the schedule of the calls, please follow @dsccommunity on twitter.

jeremyciak commented 4 years ago

@danielboth, I don't believe I have write access to this repository so I am unable to merge my PR:

danielboth commented 4 years ago

Hi @jeremyciak, got it, I thought merges were allowed when an approval was given, apparently not the case. I merged it now, thank you for your contribution!