xRDRemoteApp: Allow for multiple values with UserGroups parameter

jeremyciak commented 3 years ago

Pull Request (PR) description

This PR implements a mechanism to allow for multiple values to be supplied to the UserGroups parameter

This Pull Request (PR) fixes the following issues

Fixes #87

Task list

[x] Added an entry under the Unreleased section of file CHANGELOG.md. Entry should say what was changed, and how that affects users (if applicable).
[x] Resource documentation added/updated in README.md.
[x] Resource parameter descriptions added/updated in README.md, schema.mof and comment-based help.
[ ] Comment-based help added/updated.
[ ] Localization strings added/updated in all localization files as appropriate.
[ ] Examples appropriately added/updated.
[ ] Unit tests added/updated. See DSC Community Testing Guidelines.
[ ] Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
[x] New/changed code adheres to DSC Community Style Guidelines.

This change is

jeremyciak commented 3 years ago

@danielboth, I would love to get your feedback on this as soon as you're able to. This is a fairly straightforward adjustment. For whatever reason I have issues on my local machine trying to successfully build, but it could likely be due to my usage of PowerShell 7.1.0. It looks like all the builds passed in the CI/CD pipeline though.

gaelcolas commented 3 years ago

@jeremyciak the build should work on PS7, but the tests (i.e. hqrmtest) may not work (depending on modules, dependencies, how the code is written and all). Logs/error message would help finding the reasons, but PS7 is not supported for all modules. You can also follow this doc here to build your Fork (instead of just the PRs). https://dsccommunity.org/blog/convert-a-module-for-continuous-delivery/#attach-your-fork-to-a-free-azure-devops-organization

jeremyciak commented 3 years ago

@gaelcolas, I addressed some other things that were failing with unit test structures but the one remaining that I believe is preventing build completion seems to be with PS Script Analyzer. I get an error where it says it is executing script PSSAResource.common.Tests.ps1 and then on this (sanitized):

  Describing Common Tests - PS Script Analyzer on Resource Files
WARNING: The tests for Common Tests - New Error-Level Script Analyzer Rules, NewErrorPSSA is not being enforced. Please Opt-in!
    [-] Error occurred in Describe block 0ms
      FileLoadException: Assembly with same name is already loaded
      at <ScriptBlock>, C:\Users\username\Documents\Git\GitHub\xRemoteDesktopSessionHost\output\RequiredModules\PSScriptAnalyzer\1.19.1\PSScriptAnalyzer.psm1: line 36
      at <ScriptBlock>, C:\Users\username\Documents\Git\GitHub\xRemoteDesktopSessionHost\output\RequiredModules\DscResource.Test\0.14.1\Tests\QA\PSSAResource.common.Tests.ps1: line 73
      at DescribeImpl, C:\Users\username\Documents\Git\GitHub\xRemoteDesktopSessionHost\output\RequiredModules\Pester\4.10.1\Functions\Describe.ps1: line 213

dsccommunity / xRemoteDesktopSessionHost