search

dsccommunity / xRobocopy

DSC Module to automate Robocopy transfers
MIT License
54 stars 15 forks source link

Missing ExcludeDirs param #18

Open gerane opened 8 years ago

gerane commented 8 years ago

In the Master and Dev branch, you do not have an ExcludeDirs param

# Helper Functions
function Get-RobocopyArguments
{
    [CmdletBinding()]
    [OutputType([System.String[]])]
    param
    (
        [parameter(Mandatory = $true)]
        [System.String]
        $Source,

        [parameter(Mandatory = $true)]
        [System.String]
        $Destination,

        [System.String]
        $Files,

        [System.UInt32]
        $Retry,

        [System.UInt32]
        $Wait,

        [System.Boolean]
        $SubdirectoriesIncludingEmpty,

        [System.Boolean]
        $Restartable,

        [System.Boolean]
        $MultiThreaded,

        [System.String]
        $ExcludeFiles,

        [System.String]
        $LogOutput,

        [System.Boolean]
        $AppendLog,

        [System.String[]]
        $AdditionalArgs
    )

but when building the robocopy arguments, you are checking for the param to set /XD

if ($ExcludeDirs) 
{
    $arguments += @('/XD', $ExcludeDirs)
}

I was not sure if you meant to have ExcludeDirs or if it was removed and the added check was just forgotten about.

narrieta commented 8 years ago

@gerane : Thanks for reporting this issue