search

dsccommunity / xRobocopy

DSC Module to automate Robocopy transfers
MIT License
54 stars 15 forks source link

Dev 18 exclude dirs2 #23

Open Arturas-K opened 8 years ago

Arturas-K commented 8 years ago

Closes #18; Added workaround examples for #19;

This change is Reviewable

Arturas-K commented 8 years ago

Hi,

Code review feedback would be appreciated.

narrieta commented 8 years ago

Looks good.

I know we don't have tests for this resource, but could you add one for the new functionality?

Thanks

Review status: 0 of 5 files reviewed at latest revision, 1 unresolved discussion.

Examples/xRobocopy.SimpleCopyOptions.ps1, line 49 [r1] (raw file):

        }

        #this will exclude single file pattern using ExludeFiles option

Minor: typo. "Exclude". Several instances below

_Comments from Reviewable_

Arturas-K commented 8 years ago

I'm working on unit test coverage for this resource, i'll merge it into this branch when they are finished

Review status: 0 of 6 files reviewed at latest revision, all discussions resolved.

Examples/xRobocopy.SimpleCopyOptions.ps1, line 49 [r1] (raw file):

Previously, narrieta (Norberto Arrieta) wrote… > Minor: typo. "Exclude". Several instances below >

Done.

Comments from Reviewable

Arturas-K commented 8 years ago

as of last commit closes #24

eshaparmar commented 8 years ago

Reviewed 3 of 5 files at r1, 3 of 3 files at r2. Review status: all files reviewed at latest revision, 2 unresolved discussions.

DSCResource.Tests, line 1 at r2 (raw file):

Subproject commit c845d58d6b1f5f16ae2992f7b2c15e76d611281d

I don't see any unit tests and integration tests. Did i miss something?

Comments from Reviewable

johlju commented 6 years ago

Labeling this as abandoned as the original author has not been active after the last PR comment. A PR with the abandoned label can be continued by other contributor in the community.