search

dsccommunity / xRobocopy

DSC Module to automate Robocopy transfers
MIT License
54 stars 15 forks source link

update error catch and Get return #7

Closed mgreenegit closed 8 years ago

mgreenegit commented 9 years ago

In version 1, if the copy failed during Set the error was not properly caught and displayed. Also updating Get so that properties are displayed based on input. In most cases, I would not use input as what should be returned by Get, but after working with this resource I realize that is the only way to report on which parameters are being passed to the command.

mgreenegit commented 9 years ago

That makes sense. Only for Ensure, correct? Otherwise the details of the configuration are not stored anywhere and the original input is actually very important to know.

KarolKaczmarek commented 9 years ago

correct, I think it's fine to display original input as well if that's something user may find useful.

TravisEz13 commented 8 years ago

It is required that you provide adequate test coverage for the code you change. Contribution Guidelines -Adding test coverage for DSC resources Please work with us to come up with a plan to cover this code.

TravisEz13 commented 8 years ago

Please resolve merge conflicts. For more information see GitHowTo - 30. Resolving Conflicts

TravisEz13 commented 8 years ago

If there is no update of the pull request within 7 days, we will close the pull request. After that, if you have an update, feel free to reopen the pull request.

TravisEz13 commented 8 years ago

Closing because the pull request has not been updated for feedback given for 21 days. Once you update the code, please feel free to reopen the pull request. Thanks, Travis.