search

dschaefer / eclipse-two

A prototype IDE based on Electron
Eclipse Public License 1.0
92 stars 10 forks source link

Implement Save for the editors #10

Open dschaefer opened 7 years ago

dschaefer commented 7 years ago

Right now all you can do is open files to look at them and then close the tab. Would be good to implement save so you can save changes (yes, we're that early in this thing). Start with grabbing the Command/Control S key action and save the contents of the currently active editor into it's filePath. Also implement a dirty bit so we don't save if there hasn't been changes and so that we don't close the tab if the editor is dirty without asking the user.

marckhouzam commented 7 years ago

How about going full auto-save right away?

dschaefer commented 7 years ago

Baby steps. First I need to learn how to save at all. Monaco doesn't have a "save" function so I'll have to construct that. Then just bind it to the right key.

I'm also not sure auto-save is a feature that most developers want. We need to study that a bit more.