search

dscharrer / innoextract

A tool to unpack installers created by Inno Setup
https://constexpr.org/innoextract/
Other
1k stars 125 forks source link

When using "--collisions rename-all" filenames aren't checked for path delimiters #123

Open clst opened 3 years ago

clst commented 3 years ago

I was trying to extract a few files from the Freelancer Crossfire Installer. The options include Backslashes which makes Windows unhappy:

Extracting "Freelancer Crossfire" - setup data version 5.6.0 (unicode)
Opening "Crossfire2setup-1a.bin"
 - "app\DATA\Characters\BODIES\li_hatcher_body.dfm#Crossfire"
 - "app\DATA\Characters\BODIES\pl_trent_body.dfm#Crossfire"
 - "app\DATA\Characters\HEADS\pi_pirate5_head.dfm#Crossfire"
 - "app\DATA\INTERFACE\Intro\Images\front_freelancerlogo2.tga"
Opening "Crossfire2setup-1b.bin"
 - "app\DATA\Characters\HEADS\pi_pirate5_head.dfm#Crossfire\options\option1\choice1"
Coul not open output file "app\DATA\Characters\HEADS\pi_pirate5_head.dfm#Crossfire\options\option1\choice1"
Done with 1 error.

It works fine on Linux with ext4 where this is not an issue.

Also "Coul" is probably a typo. :)

Thanks for this really handy software, btw.