Closed wlonk closed 8 years ago
Is this backwards compatible? I'm afraid it's not. Maybe it makes sense to send user and bearer?!
Yeah, it's not. We need backwards compatibility for people who are running their own Sentry install, I suppose?
What would you say to just changing the config (in which case I'll update the docs, too) to pass in auth: { user: key }
or auth: { bearer: key }
?
yes, exactly. The problem is ... this is still a breaking change. :-/
Why not send both?
Oh, I had misunderstood. Since this is still pre 1.0, I had assumed breaking changes weren't a big deal. I had taken you to be referring to backwards compatibility with older Sentry APIs.
requests-promise
won't actually send both (they use the same header), so I've added a new config key if you want to use a bearer token.
Cool! Thanks!
I will look at this tomorrow again, probably I'll be happy and just merge! If I forget, just ping me here again
Ping!
Pinging again. Should be as you want it now!
Woah, sorry. Completely forgot about this... :(
It's OK! That's why I pinged you.
Thanks for the merge!
@dschmidt any plans on publishing a new release including this change?
Need to yes. Please ping me in a few days again
Uploading sourcemaps to Sentry was failing, due to Sentry expecting a bearer token. I've adjusted the auth options accordingly.
Per the tradition of my people, every pull request should come with a cute animal picture: