search

dschmidt / ember-cli-deploy-sentry

An ember-cli-deploy-plugin to upload javascript sourcemaps to Sentry
MIT License
42 stars 51 forks source link

Fix authentication issues #23

Closed Turbo87 closed 7 years ago

Turbo87 commented 8 years ago

This PR is fixing some issues when authenticating against sentry.io via bearer token.

Turbo87 commented 8 years ago

@dschmidt any comments?

jessepollak commented 8 years ago

+1

dschmidt commented 8 years ago

I was using request before but @duizendnegen ported my code to use form-data directly (https://github.com/dschmidt/ember-cli-deploy-sentry/pull/6) ... I'm a bit clueless here, what to do :\

duizendnegen commented 8 years ago

Uhh what kind of errors were you getting @Turbo87 when authenticating against Sentry? (is this because of their new auth?)

Turbo87 commented 8 years ago

@duizendnegen yes, it seems that formData.submit() only supports HTTP Basic Auth, but not using Bearer tokens like sentry.io is essentially requiring now. I didn't know that it was using request directly before. IMHO we should try to fix request though instead using two different form of making authenticated HTTP requests. did you try to debug your original issue or extract a reproduction?

jessepollak commented 8 years ago

Just to chime in: @Turbo87's resolved the issue for us. One semi-related thing is that the sentryApiKey is required in the validation step even if sentryBearerApiKey is set!

duizendnegen commented 8 years ago

Then let's go - I need to make the transition to Bearer anyway, and I'm not deploying with Windows anymore.

dschmidt commented 7 years ago

@duizendnegen So ... merge this? I thought you were going to take care of this, I think you have write access to this repo :D

duizendnegen commented 7 years ago

Feel free to merge, I don't have write access :)

dschmidt commented 7 years ago

Thanks a lot

dschmidt commented 7 years ago

@duizendnegen invited you as collaborator :)