search

dschmidt / ember-cli-deploy-sentry

An ember-cli-deploy-plugin to upload javascript sourcemaps to Sentry
MIT License
42 stars 51 forks source link

remove unnecessary usage of jQuery #45

Closed marcoow closed 6 years ago

marcoow commented 6 years ago

This unblocks usage of ember-cli-deploy-sentry in apps that don't bundle jQuery

duizendnegen commented 6 years ago

Cheers!

dschmidt commented 6 years ago

Cheers!

My first (ugly) implementation used no jQuery - but for whatever reason in the final PR I used jQuery... as this is basically the same as the old code just without jQuery - fine with me, let's wait for someone to complain :-)

dschmidt commented 6 years ago

If you want a quick release, mind to prepare the Changelog?

Also I would appreciate your input: Does jQuery internally have polyfills for this function that might be needed on browsers that are supported by Ember? https://caniuse.com/#search=querySelector If it was the case, it might be considered a breaking change requiring a major version bump..

What do you think?

marcoow commented 6 years ago

document.querySelector should be supported in IE8+ which is also what Ember 2.0+ supports so if ember-cli-deploy-sentry doesn't support Ember 1.x (which at least it doesn't test against), things should be fine.

marcoow commented 6 years ago

@dschmidt: changelog for 0.5.5: #46