search

dschmidt / ember-cli-deploy-sentry

An ember-cli-deploy-plugin to upload javascript sourcemaps to Sentry
MIT License
42 stars 51 forks source link

Add urlPrefix option #48

Closed dguayrobotiq closed 6 years ago

dguayrobotiq commented 6 years ago

Fixes #47

Add urlPrefix option to replace publicUrl in the file name when uploading files to Sentry's release artifacts.

If the assets are stored on Cloudfront, files would normally be named something like https://xxxx.cloudfront.net/assets/... in Sentry's release artifacts. If you set urlPrefix to ~, files will instead be named ~/assets/....

lukemelia commented 6 years ago

@dguayrobotiq Congrats on getting this figured out! Is there any reason to have both publicUrl and urlPrefix? It seems like they are used for the same purpose.

dguayrobotiq commented 6 years ago

Gosh I feel so dumb. I think you're right and my PR is useless. By reading the README, I really thought publicUrl was used to retrieve files... I can actually just set publicUrl to ~ instead of my cloudfront...

I'll test that and decline that PR...

lukemelia commented 6 years ago

@dguayrobotiq definitely not dumb -- other people could and will make the same mistake. Perhaps you could change the PR into a documentation PR that updates the README to clearly address information that would have helped "you" a week ago.