search

dschmidt / ember-cli-deploy-sentry

An ember-cli-deploy-plugin to upload javascript sourcemaps to Sentry
MIT License
42 stars 51 forks source link

moved editing of index.html from willUpload to didBuild #5

Closed duizendnegen closed 8 years ago

duizendnegen commented 8 years ago

didBuild makes more sense conceptually, since it is "the thing to do after building" and not "the thing to do before uploading". Ensuring it does run after revision data is available is by requesting the ordering in ember-cli-deploy-revision-data.

dschmidt commented 8 years ago

Your own tests are unhappy :)

dschmidt commented 8 years ago

I'm not sure this is optimal, this makes revision-data a rather strict dependency ... what if a different plugin some day provides the same data? then the ordering might break

duizendnegen commented 8 years ago

losing my license to code coughs of course I always do npm test locally before pushing

duizendnegen commented 8 years ago

I agree - we've discussed managing dependencies a bit in our f2f in London, and have decided not to release 1.0 until we have figured out a good way to deal with it - this was the consensus of the current way to move forward, but feel free to give input if you see a different direction.