Upload on didPrepare hook to fix gzip issues

dschmidt / ember-cli-deploy-sentry

An ember-cli-deploy-plugin to upload javascript sourcemaps to Sentry

MIT License

42 stars 51 forks source link

Upload on didPrepare hook to fix gzip issues #52

Closed simonihmig closed 6 years ago

simonihmig commented 6 years ago

Just another attempt at fixing/working around #26.

My super simple approach here: use another hook (didPrepare here) that runs before willUpload (where e-c-d-gzip will gzip the files) to upload the (still) uncompressed files to Sentry.

I don't know if I am missing something, but it seems to work for me. And it does not suffer from the problem of #42, which AFAICT does not work with other compression algorithms than plain gzip (e.g. zopfli, brotli).

simonihmig commented 6 years ago

Let's leave a comment in the source code

Hey @duizendnegen, just added that!

dschmidt commented 6 years ago

Well, we can try ... and wait for bug reports if it breaks anything for anyone.

simonihmig commented 6 years ago

@dschmidt can we get a release with this, please? 😀