Closed sumeetattree closed 5 years ago
I guess the idea was that I wanted to seperate sentry settings from settings that are more connected to your own project than to sentry (publicUrl). While I'm not exactly against it, I'm not sure it's worth the effort keeping things compatible and not breaking other people's pipeline...
I get what you are saying. Maybe once you want to introduce a 2.0 you can take a look at the names again. I think I'll close this for now as this will do more harm than good at this point. Thanks!
Thanks for your effort anyway! :-)
I've noticed that you are namespacing the keys twice. Because these are already inside
ENV.sentry
I think this is not required.May be change these to:
While we are at it maybe we should remove the
apiKey
and call it something else? I am not sure what the old usage was like so I am at a loss here for suggestions. We should ideally renamebearerApiKey
toapiKey
.Let me know if you'd like a pull request with these changes. Thanks!