catull
commented
6 years ago @AngryBeaver How about you create a PR against https://github.com/shamoons/ng-json-schema-form. Shamoon is the next maintainer of this library.
Open AngryBeaver opened 6 years ago
catull
commented
6 years ago @AngryBeaver How about you create a PR against https://github.com/shamoons/ng-json-schema-form. Shamoon is the next maintainer of this library.
arrays in data that changed in size needs to increase or decrease formGroup
PR Type
What changes does this PR include (check all that apply)? [x] Bugfix [ ] Feature [ ] Code style update (formatting, local variables) [ ] Refactoring (no functional changes, no api changes) [ ] Build process changes [ ] Documentation changes [ ] Other... please describe:
Related issue / current behavior
if we updateForm with changes in input only the initializeForm is not triggered.
possible fixes this: https://github.com/dschnelldavis/angular2-json-schema-form/issues/256 maybe this: https://github.com/dschnelldavis/angular2-json-schema-form/issues/195
New behavior
keep it stupid simple it always rerender Form even if the change is only in data
Does this PR introduce a breaking change?
[ ] Yes [x] No
Any other relevant information
The Change will possibly slow down as each data change will now trigger a Form rerender but its clean simple stupid and not performance optimized as i currently do not see any problems. CleanCode: http://clean-code-developer.com/grades/grade-1-red/#Keep_it_simple_stupid_KISS http://clean-code-developer.com/grades/grade-1-red/#Beware_of_Optimizations