search

dschnelldavis / angular2-json-schema-form

Angular 2 JSON Schema Form builder
MIT License
285 stars 177 forks source link

Ionic loading controllers dismiss not working properly after latest upgrade #59

Open avinashks23 opened 7 years ago

avinashks23 commented 7 years ago

I am using "angular2-json-schema-form" in an ionic 3 ("ionic-angular": "3.5.0") app. After latest upgrade "angular2-json-schema-form": "^0.4.0-alpha.18", I am facing an issue with ionic's Loading Controller. On loading dismiss, loader disappears from screen, but the overlay still remains. So, I am unable to click on other elements on the page after loading dismiss. When i disable "angular2-json-schema-form", loading controller works fine.

Last working version for me was "angular2-json-schema-form": "^0.3.0-alpha.27"

felschr commented 7 years ago

I just noticed the same issue. First I thought I broke my ionic installation.

The layout of ion-select is different when I import JsonSchemaFormModule in my AppModule. The popup of the ion-select also remains after making a selection just like your issue with the Loading Controller.

@avinashks23 does any other version work for you?

felschr commented 7 years ago

I had a look into the source code but I don't even know where I should start searching.

The angular2-json-schema-form component shouldn't exist at this point because the error already happens when only importing JsonSchemaFormModule in the AppModule. So the error can't be in a component and also not in a provider/service (as they can only be used inside components when I understand it right).

But what is left? Is it one of the 3rd party libraries? Hmm, there are basically only ajv, hammerjs and lodash.

The component selectors also seem to not interfere with Ionic components as far as I can tell.

avinashks23 commented 7 years ago

I tried with some older versions. The result might be helpful.. v0.4.0-alpha.7 - loading working v0.4.0-alpha.8 - install error (I just tried once. so, might not be any issue) 0.4.0-alpha.11 - loading not working 0.4.0-alpha.15 - loading not working

felschr commented 7 years ago

@avinashks23 I tried a few versions yesterday but couldn't find one that works for me. v0.4.0-alpha.7 gave me the error Cannot find module "@angular/cdk.

So now I tried the version again and manually installed the missing dependency and it is working now!!

cmartin81 commented 6 years ago

@avinashks23 and @FelschR : I see you guys are using ionic. Have any of you written an custom ionic form render for angular2-json-schema-form?