search

dschu012 / d2lootfilter

MIT License
44 stars 26 forks source link

condition Class != Potion causes crash #34

Open qqkookie opened 2 years ago

qqkookie commented 2 years ago

It seems that the condition Class != Potion or similar Class != expression causes hard crash on loading the filter file. Type != Super Healing Potion does not cause crash. And Class condition with non-existent class (due to spell error etc) always success and issues no error message. It make hard to track down error. Non existing class condition should issue warning.

dschu012 commented 2 years ago

This is an incomplete project, I lost time and interest. But the following is in the readme 

* Error handling. Filter just silently ignores errors right now.

It's known that errors are ignored. To track down issues I suggest using the /debug and/or the /test features.

qqkookie commented 1 year ago

Hmmm.. then may I edit and revise the source code more widely? i.e. not just small fix, but more revisions and improvement of basic functionalities of d2lootfilter and source code. I'd like to add most of improvements I suggested in the #31 by myself. If you are no longer interested in maintaining this project, I can volunteer.

dschu012 commented 1 year ago

You're welcome to fork it and change it to your will.