dscottboggs / mastodon-async

Mastodon Client for Rust
Other
34 stars 12 forks source link

Filters V2: allow to list, create and delete #139

Closed xvello closed 8 months ago

xvello commented 8 months ago

For https://codeberg.org/xvello/mastoml I needed to list, add and delete v2 filters through this client.

I did a quick and dirty addition first to unblock me, and wanted to check in with you @dscottboggs before polishing the PR for review:

Feel free to directly push on the branch or suggest changes in a review.

dscottboggs commented 8 months ago

Please note the existence of #54, the comb branch, and, more specifically to this PR, commit abafaf224c8423e68cc0489888f9e2a412048c72

If you have any capacity to offer towards the v2 push, it would be appreciated. I can review PRs, but am pretty buried with other projects right now to work on it myself.

xvello commented 8 months ago

Hello @dscottboggs, this PR builds on top of https://github.com/dscottboggs/mastodon-async/commit/abafaf224c8423e68cc0489888f9e2a412048c72, uses the new struct and wires the associated endpoints that were not yet wired.

Since this PR has been closed on sight, I'll hard fork for my personal use.

dscottboggs commented 8 months ago

Yes, that change was made before the decision to avoid further breaking changes in the v1 release cycle. All breaking changes must be a part of the v2. It's not that I don't appreciate the effort, but I have a commitment to other users of this library to maintain semver compatibility. As I said before, I closed this PR because it is targeting the wrong branch and duplicating work that has already been done. Your contributions, if they maintain semver compatibility, are more than welcome. If semver compatibility is not something you're interested in, you're also more than welcome to maintain a hard fork.

I apologize if I've made you feel as though I don't appreciate the effort.