Update board member card look and feel

dscvitc / dscvitchennai

GDSC VIT Chennai Official website

https://gdscvitc.eu.org/

MIT License

23 stars 42 forks source link

Update board member card look and feel #103

Closed Aditya-Jyoti closed 1 year ago

Aditya-Jyoti commented 1 year ago

🛠️ Fixes Issue: Closes #102

👨‍💻 Changes proposed

Proposed an update in the look of Board Member cards and made use of previously unused parameters

🔧 Check List (Check the type of issue it fixes)

[ ] Bug Fix
[ ] New Extension
[x] Enhancement
[ ] Documentation

✔️ Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[x] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings
[x] Any dependent changes have been merged and published in downstream modules
[x] I have done git pull before adding my new changes
[x] The title of my pull request is a short description of the requested changes.

📄 Note to reviewers

📷 Screenshots

Screenshot 2023-10-02 210811

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
dscvitchennai	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 2, 2023 4:41pm

Aditya-Jyoti commented 1 year ago

@EmmanuelAllanMJ @vaibhavTekk could you review this PR

EmmanuelAllanMJ commented 1 year ago

Can you update the names and their designation, use dummy data if not provided

vaibhavTekk commented 1 year ago

@Aditya-Jyoti just to clarify, this just updates the components and not the data correct ?

Aditya-Jyoti commented 1 year ago

Will push with dummy data once I'm back from class in another PR. This one was just for the CSS updates

Aditya-Jyoti commented 1 year ago

@Aditya-Jyoti just to clarify, this just updates the components and not the data correct ?

Yes, just updates the components

vaibhavTekk commented 1 year ago

@Aditya-Jyoti There's some overlap between the image and the text, can you make it so that all the images show up with the same width and height ?

Aditya-Jyoti commented 1 year ago

@Aditya-Jyoti There's some overlap between the image and the text, can you make it so that all the images show up with the same width and height ?

I faced the same issue when working with the date. The easiest method to solve it is to crop all images inside the public/leads/ folder to a square format.

I chose the manual method because for some reason setting the witdh and height as well as the padding gave inconsistent results.

I'll make cropping changes once I'm back from class

Aditya-Jyoti commented 1 year ago

closing this PR, will open a new one with all the fixes.