dscvitc / dscvitchennai

GDSC VIT Chennai Official website
https://gdscvitc.eu.org/
MIT License
23 stars 42 forks source link

Closes #60: Fix Nav 🍔 on mobile #61

Closed jessej-samuel closed 2 years ago

jessej-samuel commented 2 years ago

🛠️ Fixes Issue

Closes #60

👨‍💻 Changes proposed

🔧 Check List (Check the type of issue it fixes)

✔️ Check List (Check all the applicable boxes)

📄 Note to reviewers

📷 Screenshots

image

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
dscvitchennai ✅ Ready (Inspect) Visit Preview Oct 11, 2022 at 2:46PM (UTC)
FidalMathew commented 2 years ago

@jessej-samuel Kindly take note of this issue. image

jessej-samuel commented 2 years ago

Hey @FidalMathew , I noticed this. It's being caused by the vision section. Not related to #60. Probably open a separate issue would be clean. Or else I can fix the vision section too here itself. What do you say 🤔

image

Arjun31415 commented 2 years ago

Why do you believe it is because of the vision section, isn't the vision section width correct

Arjun31415 commented 2 years ago

image All the other sections are having the same width, except the navbar

jessej-samuel commented 2 years ago

Check the chrome inspector. The vision sections width exceeds the html's root width

FidalMathew commented 2 years ago

Padding seems to fix the issue. @jessej-samuel @Arjun31415 Remove the margins. image

jessej-samuel commented 2 years ago

Cool! I thought the gaps were causing it lol. I'll add that in a commit shortly

jessej-samuel commented 2 years ago

Alright, that's fixed ;) I really like how the site has turned out 😸

Arjun31415 commented 2 years ago

@FidalMathew add the hacktoberfest accepted tag