dsdeur / RWU

2 stars 2 forks source link

Rotation of people order #1

Open grechut opened 10 years ago

grechut commented 10 years ago

Hey,

very nice tool :) +1

It would be nice if the user could customize the order of displayed images. Maybe they should also be resized to fit the screen. Right now, I can see myself on the half of the screen. I'm talking about version with small width (400px). screen shot 2014-09-12 at 11 22 22 am

best, J

eteeselink commented 10 years ago

Related, probably: i would like all images to always fit inside the viewport, without scrolling. so some auto-image-resize-and-reshuffle to make that happen. as more people join, the images would get smaller.

dsdeur commented 10 years ago

Change order is good one, it's on the list.

My plan for the size is to make the snapshots re-sizable or make some predefined sizes from which you can choose. It would automatically jump to a smaller size if not all snapshots fit the window.

What do you think?

grechut commented 10 years ago

maybe you can make use of: https://github.com/joshwnj/react-visibility-sensor/blob/master/visibility-sensor.jsx or http://react-components.com/component/react-responsive , this should be good enough for reasonable number of photos

:)

2014-09-28 22:52 GMT+02:00 Durgé Seerden notifications@github.com:

Change order is good one, it's on the list.

My plan for the size is to make the snapshots re-sizable or make some predefined sizes from which you can choose. It would automatically jump to a smaller size if not all snapshots fit the window.

What do you think?

— Reply to this email directly or view it on GitHub https://github.com/dsdeur/RWU/issues/1#issuecomment-57099699.

Pozdrawiam, Jacek Rzeszutek

eteeselink commented 10 years ago

Damn, I hate most of the open source React components that pop up :-) The visibility sensor uses an interval timer instead of scroll/resize events.

React-responsive is pretty cool though. I had a complaint but then I realized it's pretty cool. Just make sure to use the prop syntax and to hardcode the breakpoints in some constants file.