dsebastien / obsidian-dataview-serializer

Obsidian plugin that gives you the power of Dataview, but generates Markdown, making it compatible with Obsidian Publish, and making the links appear on the Graph.
https://developassion.gitbook.io/obsidian-dataview-serializer
MIT License
68 stars 7 forks source link

Add an empty line between the serialised query and <!-- SerializedQuery END --> #22

Open efsalvarenga opened 2 months ago

efsalvarenga commented 2 months ago

First and foremost, I wish I've found this plugin earlier. It is awesome.

I do have one suggestion though:

Right now there is no empty lines between the end of the serialised query and the END. This works fine on obsidian, but not if you are using the .md files to render a webpage (using Jekyll, for example).

Adding an empty line between sorts it out, but I would prefer to not have to do it manually.

Would something like this be possible?

Many thanks Estevao

dsebastien commented 2 months ago

Hi @efsalvarenga. Glad you like it! I'll try to add this, but can't promise when, I have many other things going on right now.

efsalvarenga commented 2 months ago

Thanks for the message. No worries, it works well with lists, so I use them for now.

quantumgardener commented 2 months ago

I'm happy to look at this, but suggest it's an option somewhere. Why? Because I'm rendering using Quartz and there is no need for a blank line at the end with my formatting.

dsebastien commented 2 months ago

Good point ☝️

Le lun. 23 sept. 2024 à 13:30, quantumgardener @.***> a écrit :

I'm happy to look at this, but suggest it's an option somewhere. Why? Because I'm rendering using Quartz and there is no need for a blank line at the end with my formatting.

— Reply to this email directly, view it on GitHub https://github.com/dsebastien/obsidian-dataview-serializer/issues/22#issuecomment-2367941222, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAV6H3APZOUNQZZK3MBRKLZX73XHAVCNFSM6AAAAABNNYO5QGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRXHE2DCMRSGI . You are receiving this because you commented.Message ID: @.***>

quantumgardener commented 1 month ago

Hi @efsalvarenga, is there any chance you can provide a screenshot of what you are seeing in Obsidian and how it is being displayed in Jekyll? I'm having a little trouble understanding what you are asking for and I'll need to be able to determine if there is actually a blank line missing or if it's just formatting. Could you also link me to a web page where you have a query?

Thanks, David

efsalvarenga commented 1 month ago

Hi @quantumgardener yes I can.

See this github page: https://terra-campaigns.github.io/ouro/#timeline

The first part is the list, which works. The second is the table (only substituting LIST with TABLE) and it does not render correctly through jekyll. If you clone this repository on your machine, you will see that it works well on obsidian itself.

image
quantumgardener commented 1 month ago

Ok, I can see the empty line compared to the list. I expect that is just blank padding around a table but I'll see what I can test. I don't have any situations in my vault where I'm using a list.

It might just be you've done this as a demo, but if not, to clear up the table heading, add as "Column name" to remove the problem on the website page. When a table column is created from an expression and not named, dataview uses the expression. It's probably not helping here and stopping the first row of the table from appearing on it's own line.

region + ","... + parent + ")" as Timeline

If that is the cause of the problem, please confirm.

efsalvarenga commented 1 month ago

Hi, thanks.

Yes, I made the table just as a demo. The issue is not the title, but the absence of an empty line before the <!-- SerializedQuery END --> line. And it only happens when rendering the markdown in html.