Slide durations are constant, incorrect

dseif / slide-drive

Slideshow using audio/video to drive content

45 stars 9 forks source link

Slide durations are constant, incorrect #37

Closed banksJeremy closed 12 years ago

banksJeremy commented 12 years ago

This is what I get for testing with only a single slide for so long... slides that are read from the document are given a constant duration, instead of a calculated one. If the second slide is at 3s then the first slide should be 3s long, but it's not.

(Tag this as another priority regression.)

dseif commented 12 years ago

Do you not have permissions to set Labels/change milestones? If not I can give that too you ( I think )

banksJeremy commented 12 years ago

I do not. I can close issues I open, but that's it.

dseif commented 12 years ago

How about now?

banksJeremy commented 12 years ago

Working, thanks!

dseif commented 12 years ago

You should have permissions to push as well, but please hold off on that unless it's necessary as we should continue with the review process we have going.

banksJeremy commented 12 years ago

Sure.

Fixed in 1531635eed.

dseif commented 12 years ago

Sweet, looks good to me, feel free to merge with master