dseight / vscode-disasexpl

Disassembly Explorer for VS Code
MIT License
48 stars 11 forks source link

couple of additions #26

Open gatchamix opened 2 years ago

gatchamix commented 2 years ago

the previous solution of delaying before calling update is inconsistent - with larger files or on specific filesystems, the file may not be released before the delay expires (I could reproduce this using WSL2).

There's no 'one size fits all' solution down this path, and adding a customisation option for the delay seems messy. Instead, I've added completion events for change/delete which avoid this issue.

-

I also added support for multiple associations per key - clang and gcc currently have different output formats when using -save-temps (one generates .ext.s, the other .s which required changes to the associations settings when switching between compilers.

Having an array of associations solves this problem, while also giving additional flexibility for those that want to take advantage of it. An alternative would be to support regular expressions or some other form of 'complex' matching