dseinternational / open-dotnet

Libraries and tools supporting DSE Open systems and technologies.
MIT License
0 stars 0 forks source link

Avoid some variable length stackallocs #171

Closed rabuckley closed 1 month ago

rabuckley commented 1 month ago

Codegen is much better when stack allocating fixed sized spans. There are some more but these seemed like the most-used paths.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 89.58333% with 5 lines in your changes missing coverage. Please review.

Project coverage is 47.6%. Comparing base (88f2463) to head (213a437). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...erialization/JsonSpanSerializableValueConverter.cs 76.9% 3 Missing :warning:
...lization/JsonUtf8SpanSerializableValueConverter.cs 94.7% 1 Missing :warning:
src/DSE.Open/MemoryExtensions.AsciiChar.cs 0.0% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #171 +/- ## ===================================== Coverage 47.6% 47.6% ===================================== Files 755 755 Lines 36702 36719 +17 Branches 2925 2928 +3 ===================================== + Hits 17478 17512 +34 + Misses 18119 18102 -17 Partials 1105 1105 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.