dselivanov / text2vec

Fast vectorization, topic modeling, distances and GloVe word embeddings in R.
http://text2vec.org
Other
852 stars 136 forks source link

Partial matching in LDA code #346

Closed chainsawriot closed 3 months ago

chainsawriot commented 3 months ago

This C++ function asks for n_topics

https://github.com/dselivanov/text2vec/blob/dce877b2e315fc9f7678929cb0665a751465b5cb/src/warplda.cpp#L149-L156

while here n is passed.

https://github.com/dselivanov/text2vec/blob/dce877b2e315fc9f7678929cb0665a751465b5cb/R/model_LDA.R#L218-L220

PR will follow.

I detect this by setting the following options

options(
  warnPartialMatchArgs = TRUE,
  warnPartialMatchAttr = TRUE,
  warnPartialMatchDollar = TRUE
)