search

dsgibbons / shap

A game theoretic approach to explain the output of any machine learning model.
https://shap-community.readthedocs.io/en/latest/
MIT License
25 stars 5 forks source link

Fix tests #4

Closed dsgibbons closed 1 year ago

dsgibbons commented 1 year ago

Problem

The tests run by GitHub actions always fail. There appear to be multiple failures that contribute to this. Individual issues will be raised regarding each failure condition.

Success criterion

Refactor the code, dependencies and tests so that all tests run successfully.

connortann commented 1 year ago

I think we're most of the way there now, just some matplotlib issues to sort.

I had a go reproducing the failing image diff tests locally (tests.plots.test_heatmap): it looks like the heatmap plot is now currently being plotted a bit vertically lower in the figure:

image

dsgibbons commented 1 year ago

Oh I was literally just working on this! I'm about to open a PR

dsgibbons commented 1 year ago

See https://github.com/dsgibbons/shap/pull/29

connortann commented 1 year ago

@thatlittleboy I think the waterfall plot tests are not fully fixed (from #62), as they still fail on python 3.7.

Related: #69, #73