search

dsgibbons / shap

A game theoretic approach to explain the output of any machine learning model.
https://shap-community.readthedocs.io/en/latest/
MIT License
25 stars 5 forks source link

Separate out tests of optional dependencies, add new unit test job #61

Closed connortann closed 1 year ago

connortann commented 1 year ago

Closes #46

Defines two dependency groups, test-core and test-extras. The group tests remains as the union of both.

Adds an extra CI job to run tests with core dependencies only.

connortann commented 1 year ago

Thanks for this, but I think this one needs some further deliberation.

Sure, no problem. Thanks for the review comments!

(Also don't really want to merge this in now, since it might slow down our PRs).

May I ask, what in these changes do you think may slow down PRs? Are you concerned about the total time for GH Checks to complete, or something else?

thatlittleboy commented 1 year ago

Initially I was worried about the total time, but I see now it's not going to be an issue.